Skip to content

Conversation

@nischitpra
Copy link
Contributor

@nischitpra nischitpra commented Feb 11, 2025

PR-Codex overview

This PR introduces error handling for cache operations in Cloudflare workers by adding a .catch block to log any errors that occur during the put operation in the kvStore.

Detailed summary

  • Added a .catch block to the put method in packages/service-utils/src/cf-worker/index.ts to log errors.
  • Maintained the original structure of the put operation while enhancing its robustness.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@nischitpra nischitpra requested a review from a team as a code owner February 11, 2025 12:05
@changeset-bot
Copy link

changeset-bot bot commented Feb 11, 2025

🦋 Changeset detected

Latest commit: 0a29213

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@thirdweb-dev/service-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 0:33am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Feb 11, 2025 0:33am
login ⬜️ Skipped (Inspect) Feb 11, 2025 0:33am
thirdweb_playground ⬜️ Skipped (Inspect) Feb 11, 2025 0:33am
wallet-ui ⬜️ Skipped (Inspect) Feb 11, 2025 0:33am

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 11, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@codecov
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.81%. Comparing base (dceb47d) to head (0a29213).
Report is 43 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6230   +/-   ##
=======================================
  Coverage   56.81%   56.81%           
=======================================
  Files        1163     1163           
  Lines       64342    64342           
  Branches     5213     5213           
=======================================
  Hits        36556    36556           
  Misses      27057    27057           
  Partials      729      729           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from d34f84d
packages 55.01% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.21 KB (0%) 925 ms (0%) 645 ms (+85.14% 🔺) 1.6 s
thirdweb (cjs) 121.86 KB (0%) 2.5 s (0%) 721 ms (-26.08% 🔽) 3.2 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 160 ms (+312% 🔺) 272 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 7 ms (-67.51% 🔽) 17 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 155 ms (+6.89% 🔺) 541 ms

},
)
.catch((e) => {
console.warn(e);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, shouldn't the consumer handle this if they want?

@nischitpra nischitpra closed this Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants